Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflows): update #373

Merged
merged 5 commits into from
Jan 30, 2025
Merged

ci(workflows): update #373

merged 5 commits into from
Jan 30, 2025

Conversation

SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Nov 27, 2024 •
edited
Loading

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run compile).
  • Run npm run lint w/o errors.

@SunsetTechuila
Copy link
Member Author

probably this should be merged without squashing

@SunsetTechuila SunsetTechuila changed the title ci(workflows): update actions ci(workflows): fix actions Nov 27, 2024
@SunsetTechuila SunsetTechuila changed the title ci(workflows): fix actions ci(workflows): fix workflows Nov 27, 2024
@SunsetTechuila SunsetTechuila changed the title ci(workflows): fix workflows fix workflows Nov 27, 2024
@SunsetTechuila SunsetTechuila force-pushed the ci branch 2 times, most recently from 8be982f to f0d68c0 Compare December 6, 2024 23:08
@xuhdev
Copy link
Member

xuhdev commented Jan 30, 2025

Thanks for your contribution. We favor #380 instead, because it also brought ancient dependencies up-to-date.

@xuhdev xuhdev closed this Jan 30, 2025
@SunsetTechuila
Copy link
Member Author

SunsetTechuila commented Jan 30, 2025 •
edited
Loading

@xuhdev your PR doesn't:

  • introduce a caching step, despite the fact that VSCode downloading take up most of the workflow execution time
  • update the ancient github actions

@xuhdev xuhdev reopened this Jan 30, 2025
xuhdev
xuhdev reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you can rebase

@SunsetTechuila SunsetTechuila changed the title fix workflows ci(workflows): update Jan 30, 2025
@SunsetTechuila SunsetTechuila force-pushed the ci branch 2 times, most recently from 239026d to 3576f34 Compare January 30, 2025 08:42
@SunsetTechuila SunsetTechuila changed the title ci(workflows): update update workflows, downgrade and pin some packages Jan 30, 2025
@SunsetTechuila SunsetTechuila force-pushed the ci branch 2 times, most recently from 53c1eb2 to 82dd58d Compare January 30, 2025 08:47
@SunsetTechuila SunsetTechuila changed the title update workflows, downgrade and pin some packages ci(workflows): update Jan 30, 2025
@SunsetTechuila
chore(pr template): npm run compile -> npm run build
eb236ce
@SunsetTechuila
Revert "ci(workflows/test): cache vscode installation"
2c91790 
This reverts commit 0294aa5.
Don't remember why I was thinking that this significtly reduces workflow execution time, but now I cheked it and it doesn't.
@xuhdev xuhdev merged commit 67fb170 into editorconfig:main Jan 30, 2025
3 checks passed
@xuhdev
Copy link
Member

xuhdev commented Jan 30, 2025

Thanks!

@SunsetTechuila SunsetTechuila deleted the ci branch January 30, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunsetTechuila @xuhdev